nishiki-tech / nishiki-frontend

Nishiki is an app for tracking and sharing food inventories within groups for better pantry management.
https://nishiki.tech
MIT License
17 stars 5 forks source link

Feature: Adjust the UI & behavior of the login form #286

Closed nick-y-ito closed 4 months ago

nick-y-ito commented 4 months ago

Overview

This PR adjusts the UI and the behavior of the login form. It is essentially done by overriding the styles of the third-party component using the vanilla CSS.

Changes

Notes

Related future issues:

Screen Captures

https://github.com/nishiki-tech/nishiki-frontend/assets/99148565/0bf9db0b-1463-49a6-b47f-a36ef5becb19

Assignee Checklist:

Reviewer Checklist:

nick-y-ito commented 4 months ago

I just realized that there was another issue, which is when an authentication has a problem, it cannot exit the loading state. I recreated the situation by commenting out the auth related environment variables.

Let me fix it in this PR. I will add a timeout and an alert.

https://github.com/nishiki-tech/nishiki-frontend/assets/99148565/846875dc-f25f-47fa-97a1-b1c88104ca67

nick-y-ito commented 4 months ago

@kanta1207 @ShoeheyOt Could you please check if the behavior is acceptable?

ShoeheyOt commented 4 months ago

@nick-y-ito Hey Nick, it is working in my local, but please let me ask you, is there any reason you set 15 seconds?? I might leave the page if loading is more than 5 seconds, my preference though.

nick-y-ito commented 4 months ago

@ShoeheyOt

Good question!

The "15s" timeout is not determined based on the user's patience, but rather as a fallback to provide a way to exit the loading state.

While it's unlikely, there may be cases where loading the Google authentication takes longer, especially when using a slow internet connection. In such cases, waiting for only "5s" may not be sufficient to complete the loading process. So it must be long enough, yet not too long.

ShoeheyOt commented 4 months ago

@nick-y-ito Thank you for explanation , I see the point the time is not preference or improving UX, but for in case like slow internet connection.

nick-y-ito commented 4 months ago

@ShoeheyOt Yes, but it's not only for the case of slow internet. It's just one of the possible cases.

Anyway, thank you for your review and for sharing your thoughts :)

nick-y-ito commented 4 months ago

@kanta1207 @ShoeheyOt cc @kotaaaa If you find any issues later on, please let me know! For now, I will merge this PR.

Thank you for your reviews!