Feature: Rename container api in group single page - Githubissues

nishiki-tech / nishiki-frontend

Nishiki is an app for tracking and sharing food inventories within groups for better pantry management.

https://nishiki.tech

MIT License

21 stars 5 forks source link

Feature: Rename container api in group single page #297

Closed ShoeheyOt closed 7 months ago

ShoeheyOt commented 7 months ago

Overview

add funciton to rename container

Changes

add putRenameContainer function as sending request to API
add renameContainer function as validate input, if valid call the putRenameContainer

Review points

I would appreciate if variable name and documentation be reviewed

Screen Captures

No screen capture as no UI changes

Assignee Checklist:

[X] The naming convention of the PR title is correct (See the comment at the top of this template)
[X] The base branch is correct (See: Types of Branches)
[X] The branch name follows the Branch Naming Conventions
[X] The correct assignees and reviewers have been designated for this PR
[X] The coding style follows the Coding Style Guide
[X] All the related issues are associated with this PR
[X] All criteria in the associated issues are met (please tick the checkboxes)
[X] My changes do not generate new warnings or errors (especially in the console)

Reviewer Checklist:

[x] Double-check the "Assignee Checklist"
[x] The code follows the generic best practices and our Coding Style Guide
[x] The code is well-commented and easy to understand
[x] The UI changes accurately reflect the provided design

ShoeheyOt commented 7 months ago

@nick-y-ito Thank you for your review!!

gap between container,

I add gap-3(12px) as in Figma, please see the below image, so it should be fine now.

For position of Icon when the error message appears,

I took out className items-center in <RenameContainerForm> component so that the icon will no longer stick to the verticaly center when the message appears Please check the below video how it looks like now.

Icon_position_with_alert.webm