Closed nick-y-ito closed 4 months ago
The look of the icon on Android is not as expected. The image should fill the entire icon.
↓
I needed to specify the icons as "maskable" in manifest.ts
. It's solved now.
@kanta1207 @ShoeheyOt @kotaaaa Please review this PR when you have time. Thank you!
@hitohata @taniguchiiqqq Could you also test if you can install it as a PWA and the rounded icon is displayed correctly on Windows and Linux, please?
@nick-y-ito Thank you for your work! I tried to use it on Windows, Linux laptop and iPhone. It's All LGTM :)
@hitohata @ShoeheyOt @kanta1207 Thank you for your reviews!😄
Overview
This PR introduces our LOGO everywhere, such as favicon, touch icon, and OG image.
Changes
public/images/icons/favicon.ico
icons
property inlayout.tsx
public/images/og.png
openGraph
andtwitter
property inlayout.tsx
public/images/icons/apple-touch-icon.png
icons
property inlayout.tsx
viewport.themeColor
inlayout.tsx
manifest.ts
)public/images/icons/manifest/
manifest.ts
shortcuts
for installation display (See the video below)maskable
andany
icons toicons
propertyappConst.ts
and configured the app informationReview points
Sorry for the large quantity of changed files, but there are only three files that you need to focus on for a review:
Other files are just image modifications or directory refactoring.
Screen Captures
Favicon (on Google Chrome of MacBook)
Favicon (on Google Safari of MacBook)
Touch Icons on iPhone, Android, Mac, Windows and Linux
All requirements for PWA are fulfilled
PWA on Android
https://github.com/nishiki-tech/nishiki-frontend/assets/99148565/70343cdd-9eea-433a-8d7f-53910c34bd8c
https://github.com/nishiki-tech/nishiki-frontend/assets/99148565/55a75124-6ffa-40d9-b390-0887d7185219
PWA with Google Chrome on MacBook
https://github.com/nishiki-tech/nishiki-frontend/assets/99148565/ad5bd8a7-55d9-4bda-b203-2e3944192df1
References
Icons
public
Image Generators
Web Manifest
Meta Data
Twitter Card
OGP
Notes
-
Assignee Checklist:
Reviewer Checklist: