Feat: Implement "Delete account" UI

kanta1207 commented 4 months ago

Overview

Implement the UI of "Delete account" feature in Profile page.

Changes

Implement dropdown menu in profile page header
Implement DeleteAccountDialog in profile page
Add 16px align offset to the dropdown menu in group single page header (Out of the issue scope)
Implement LogoutDialog in profile page (Out of the issue scope)

Screen Captures

`LogoutDialog` and `DeleteAccountDialog` in Profile page

https://github.com/nishiki-tech/nishiki-frontend/assets/99339182/523d6e7a-7907-470e-98c9-12750597687b

16px align offset of DropdownMenu in GroupSinglePage header

Assignee Checklist:

[x] The naming convention of the PR title is correct (See the comment at the top of this template)
[x] The base branch is correct (See: Types of Branches)
[x] The branch name follows the Branch Naming Conventions
[x] The correct assignees and reviewers have been designated for this PR
[x] The coding style follows the Coding Style Guide
[x] All the related issues are associated with this PR
[x] All criteria in the associated issues are met (please tick the checkboxes)
[x] My changes do not generate new warnings or errors (especially in the console)

Reviewer Checklist:

[ ] Double-check the "Assignee Checklist"
[ ] The code follows the generic best practices and our Coding Style Guide
[ ] The code is well-commented and easy to understand
[ ] The UI changes accurately reflect the provided design

kanta1207 commented 3 months ago

@nick-y-ito Thank you for the reviews! I fixed the points you mentioned, and also left a comment on the points I wasn't so sure about.

About the refactoring, I did the renaming of Logout to SignOut. (I used camel case because signout cause an spelling caution in the editor.) I didn't do much on the directory structure, so enter or space key doesn't work in the delete or sign out dialog, although it might not be necessary for these two tho.

Please take a look anytime when you have a moment!

kanta1207 commented 3 months ago

@nick-y-ito Thank you for your suggestions! I added comments and refactor the variable/variant names following your suggestions, please have a look when you have a moment 🙏

kanta1207 commented 3 months ago

@nick-y-ito

What I meant here was to name them as danger and danger-outline instead of error and error-outline.

Sorry, it's just an excuse but I thought I left a comment like "changing all of error variant to danger would be too big, so I chose to align it error & error-outline for now", but it was pending and couldn't deliver to you. Just wanted to let you know I didn't mean to ignore your suggestion or anything 🙏 And, at the end I aligned all of them into danger & danger-outline. I just changed my mind 😅 .

Also, sorry for missing the build error! I just fixed them. Please take a look when you have a time again, kindly 🙏

kanta1207 commented 3 months ago

@nick-y-ito I renamed the log out to sign out! Please have a look when you have a moment, again 🙏

kanta1207 commented 3 months ago

Thank you for all of your reviews! I'm gonna merge this PR 👍

nishiki-tech / nishiki-frontend