nishiki-tech / nishiki-frontend

Nishiki is an app for tracking and sharing food inventories within groups for better pantry management.
https://nishiki.tech
MIT License
21 stars 5 forks source link

Refactor: Restructure component layers for meatball button on GroupSinglePage #351

Closed nick-y-ito closed 6 months ago

nick-y-ito commented 6 months ago

Overview

This PR simplifies the component nesting of the meatball button on GroupSinglePage, fixes the issue where spaces can't be entered in the renaming input, and ensures the dropdown menu disappears after the drawer/dialog opens.

Changes

Review points

Screen Captures

It looks working with a cursor control.

https://github.com/nishiki-tech/nishiki-frontend/assets/99148565/aa33dbda-f8fa-4daf-bf60-8e3bb79cef7f

It also looks working perfectly with keyboard navigation.

https://github.com/nishiki-tech/nishiki-frontend/assets/99148565/9ad9e182-3206-40d3-b270-5d3a62a5438b

Notes

-

Assignee Checklist:

Reviewer Checklist:

nick-y-ito commented 6 months ago

@kanta1207 Thank you for your review! As you suggested, I added explanations on how to use useAutoFocus.

I will merge this anyway :)