Feat: Implement update user API client and apply it to rename user form - Githubissues

nishiki-tech / nishiki-frontend

Nishiki is an app for tracking and sharing food inventories within groups for better pantry management.

https://nishiki.tech

MIT License

21 stars 5 forks source link

Feat: Implement update user API client and apply it to rename user form #352

Closed kanta1207 closed 6 months ago

kanta1207 commented 6 months ago

Overview

Implement Update user API client, and apply it to rename user form to rename user. I didn't add refresh feature in this PR

Changes

Add API client in user.ApiClient.client.ts
Add renameUser action
Apply it to RenameUserForm

Screen Captures

https://github.com/nishiki-tech/nishiki-frontend/assets/99339182/e5d940c6-3486-42e5-9962-5fb2751d95d5

Assignee Checklist:

[x] The naming convention of the PR title is correct (See the comment at the top of this template)
[x] The base branch is correct (See: Types of Branches)
[x] The branch name follows the Branch Naming Conventions
[x] The correct assignees and reviewers have been designated for this PR
[x] The coding style follows the Coding Style Guide
[x] All the related issues are associated with this PR
[x] All criteria in the associated issues are met (please tick the checkboxes)
[x] My changes do not generate new warnings or errors (especially in the console)

Reviewer Checklist:

[x] Double-check the "Assignee Checklist"
[x] The code follows the generic best practices and our Coding Style Guide
[x] The code is well-commented and easy to understand
[x] The UI changes accurately reflect the provided design

kanta1207 commented 6 months ago

@nick-y-ito Thank you for the review and quick approval! I deleted @property tag and instead wrote a comment above the property. (Didn't do the refactoring for all of the other @property tag, tho)