nishiki-tech / nishiki-frontend

Nishiki is an app for tracking and sharing food inventories within groups for better pantry management.
https://nishiki.tech
MIT License
21 stars 5 forks source link

Fix: Add loading state #368

Closed arthathagary closed 6 months ago

arthathagary commented 6 months ago

…rawercontent): loading State

Add loading state to prevent multiple submission

Overview

In this PR, I create loading state to prevent multiple form section in the following forms create group form, add food form and update food form.

Changes

-

Review points

-

Screen Captures

https://drive.google.com/file/d/1hSf8FslvkSzYn6lqJIv1VfIw15CWsdIt/view?usp=sharing

-

Notes

I think we need to create a good looking toast rather that using basic javascript alert

-

Assignee Checklist:

Reviewer Checklist:

arthathagary commented 6 months ago

Now, Check the PR, I think all okay now? If any issue arise tell me that 🤝. This is the demo - https://drive.google.com/file/d/1o0OTACoUasuwBxfHCZSYuta378VfduwB/view?usp=sharing

nick-y-ito commented 6 months ago

@arthathagary Hello! Are you going to resume this PR? If not, I may either close it or take over the task.

May I know your thoughts, please?

nick-y-ito commented 6 months ago

@arthathagary Hi, how are you doing? Thank you for making changes earlier!

I've resolved the conflict by creating a new branch. You can merge it to your branch and update your PR. So that I can quickly approve and merge your RP. https://github.com/nishiki-tech/nishiki-frontend/pull/381

If you are not going to continue or are not responding for a day, I will take over this task.

nick-y-ito commented 6 months ago

This PR has been moved to #381