Closed ShoeheyOt closed 3 months ago
@nick-y-ito Thank you for the review! I updated what you have pointed out.
As you pointed out, I changed ContainerCardDropdownMenuTrigger
to ContainerCardDropdownMenu
as it is not only a trigger anymore, Please take a look below diagram how I changed the directtory structure and file name.
before | after |
---|---|
Overview
Restructuring in order to avoid nesting root in root
Changes
The below diagram is component (+'Root') structure,
the left is what it was and the right is what I changed. As you see, I put
DialogRoot
in same level asDropdownMenu
Screen Captures
This screen capture is controled by Mouse
KebabMenuonContainerCardwithMouse.webm
This one is by Keyboard
KebabMenuonContainerCardwithKeyBoard.webm
Assignee Checklist:
Reviewer Checklist: