nishiki-tech / nishiki-frontend

Nishiki is an app for tracking and sharing food inventories within groups for better pantry management.
https://nishiki.tech
MIT License
11 stars 5 forks source link

Refactor/ Restructure component layers for kebab button on containercard #369

Closed ShoeheyOt closed 3 months ago

ShoeheyOt commented 3 months ago

Overview

Restructuring in order to avoid nesting root in root

Changes

The below diagram is component (+'Root') structure,
the left is what it was and the right is what I changed. As you see, I put DialogRoot in same level as DropdownMenu

Before After
containerKebabButtonbefore drawio containerKebabButton drawio

Screen Captures

This screen capture is controled by Mouse

KebabMenuonContainerCardwithMouse.webm

This one is by Keyboard

KebabMenuonContainerCardwithKeyBoard.webm

Assignee Checklist:

Reviewer Checklist:

ShoeheyOt commented 3 months ago

@nick-y-ito Thank you for the review! I updated what you have pointed out. As you pointed out, I changed ContainerCardDropdownMenuTrigger to ContainerCardDropdownMenu as it is not only a trigger anymore, Please take a look below diagram how I changed the directtory structure and file name.

before after
containerKebabButton-directorystructurebefore drawio containerKebabButton-directorystructure drawio