nishiki-tech / nishiki-frontend

Nishiki is an app for tracking and sharing food inventories within groups for better pantry management.
https://nishiki.tech
MIT License
11 stars 5 forks source link

Refactor: restructure component layers for kebab button on groupcard #389

Closed ShoeheyOt closed 3 months ago

ShoeheyOt commented 3 months ago

Overview

This PR is for refactoring, changing structure

Changes

The below 2 diagrams are comparison of how I changed component structure. Before

graph TD;
GroupCard --> GroupCardContent;
GroupCardContent --> RenameGroupForm & Card;
Card --> GroupCardDropdownMenuTriggerButton;
GroupCardDropdownMenuTriggerButton --> DropdownMenu;
DropdownMenu --> GroupCardDropdownMenuContent;
GroupCardDropdownMenuContent --> DropdownMenuContent;
DropdownMenuContent --> DeleteGroupDialogTriggerButton;
DeleteGroupDialogTriggerButton --> DialogRoot;
DialogRoot --> DeleteGroupDialogContent;

After

graph TD;
GroupCard --> GroupCardContent;
GroupCardContent --> RenameGroupForm & Card;
Card --> GroupCardDropdownMenu;
GroupCardDropdownMenu --> DropdownMenu & DialogRoot;
DropdownMenu --> GroupCardDropdownMenuContent;
DialogRoot --> DeleteGroupDialogContent

Screen Captures

screen-capture.webm

Assignee Checklist:

Reviewer Checklist: