Closed nick-y-ito closed 10 months ago
I agree on this file structure
Created the src/components/ui/SelectionDrawer directory and indexed all the SelectionDrawer-related modules in SelectionDrawer. They are re-indexed in src/components/ui/index.ts. Do you think this structure is OK?
.
If we don't create index.ts for the files under SelectionDrawer, src/components/ui/index.ts will get messier with multiple path for SelectionDrawer.
We can follow this structure convention when we're making other components with multiple files, too
File naming also seems to be fine, too. It's indeed a bit long but efficient, I can't come up with any way to shorten them.
So overall, LGTM!
Overview
Implemented "SelectionDrawer" components and required child components listed below
Also created the Label component and put it right under the
ui/
directory since it is unstyled and could be reused across the project. Instead, I added the variant to it, especially for the SelectionDrawer.Review Points
src/components/ui/SelectionDrawer
directory and indexed all the SelectionDrawer-related modules in theSelectionDrawer/
directory. They are re-indexed insrc/components/ui/index.ts
. Do you think this structure is OK?Note
Screenshots
https://github.com/genesis-tech-tribe/nishiki-frontend/assets/99148565/f33a3937-ccee-44d3-97fb-7042398d1069