search

nishio-dens / bitbucket-pullrequest-builder-plugin

Bitbucket Pull Request Builder Plugin for Jenkins
Other
125 stars 145 forks source link

Fix build status update issue on Jenkins v2.140 and later #158

Closed ghost closed 6 years ago

ghost commented 6 years ago

There is a weird logic difference between when we need to update build status to in progress and success/failed. With existing logic, when updating build status to success/failed, on Jenkins v2.140 somehow it reported that the Jenkins Root URL is not configured, while it is. So the fix is to use the same logic as on updating to in progress.

CodeMonk commented 6 years ago

@geraldikusuma I just merged another PR (Yours, I believe) - Can you please fix this one so I can merge it too, if the other didn't deprecate it?

ghost commented 6 years ago

I see. It seems the other PR kind of deprecated my changes. I'll get back to you later. @CodeMonk when do you plan to release the update?

CodeMonk commented 6 years ago

@geraldikusuma ASAP. But, that means in a week or two, since this is my first release.

I'm just trying to get in the last couple of low hanging fruits before we get out an update

ghost commented 6 years ago

Alright then. Thanks! I actually just updated the branch. To check for null/empty root URL. I'll open another PR from the same branch @CodeMonk