search

nishio-dens / bitbucket-pullrequest-builder-plugin

Bitbucket Pull Request Builder Plugin for Jenkins
Other
125 stars 145 forks source link

Add git clone URL to build specification #202

Closed rpanak-generalbytes closed 5 years ago

rpanak-generalbytes commented 5 years ago

This adds git URL to the scheduled build specification. It actually solves a problem of mine where a pre-build merge (i.e. merge a feature branch from the BitBucket pull request into master before running the build on Jenkins) would fail because this information was not available. The investigation was done a long time ago, so the details are hazy. Anyway, I've changed the API call only for the cloud version. Works for me, but help with testing for BitBucket Server instance would be appreciated. I think according to the BitBucket Server API docs there should be no change needed. I think the worst that can happen is a null field for the BitBucket Server.

CodeMonk commented 5 years ago

Will start looking at this tonight.

I also cannot test with server. Hopefully the author of those changes will chime in . . .

But, I'm happy to merge after review and some hand testing without server blessing.

-Dave

rpanak-generalbytes commented 5 years ago

hi, any progress on this? Anything I can do to help?

CodeMonk commented 5 years ago

I'm going to review, then merge if I don't find anything.

Hopefully, someone can help test the official builds.

Sorry for the delay, I've been slacking.

CodeMonk commented 5 years ago

@rpanak-generalbytes Looks good. I did have some nits in my review, so if you wouldn't mind putting up another PR with the nits, I'd appreciate it. All were comment / naming issues. Code / logic all looked great.

My plan is to get a build and run it at my office, to test. I hope anyone else who has cycles will do the same.

rpanak-generalbytes commented 5 years ago

Great, thanks. I've created another PR (#206) with logging and comments.