nishio-dens / bitbucket-pullrequest-builder-plugin

Bitbucket Pull Request Builder Plugin for Jenkins
Other
125 stars 145 forks source link

Builder does not handle error responses from Bitbucket very well #214

Open stevemuskiewicz opened 4 years ago

stevemuskiewicz commented 4 years ago

There have been a rash of Bitbucket cloud outages in the last week (https://www.theregister.co.uk/2019/10/02/bitbucket_recurring_outages/) and still seems to be happening intermittently.

The problem with these is that whatever response Bitbucket is returning (seems often be a 500 server error followed by HTML content) is not being handled well by the pull request builder with the result being that we get a rash of new builds for all of our open PRs even though none of the branches associated with them have changed.

It has been difficult to dig thru Jenkins logs whenever this happens as the (HTML) content coming back from Bitbucket keeps getting logged entirely so our Jenkins log is polluted with all sorts of stuff. If there is a specific string I should look for to help debug this I can try to dig that out.

CodeMonk commented 4 years ago

The 429 handling is just as bad, and happens way more often than bitbucket outages.

On Sat, Oct 5, 2019 at 6:51 AM Steve Muskiewicz notifications@github.com wrote:

There have been a rash of Bitbucket cloud outages in the last week ( https://www.theregister.co.uk/2019/10/02/bitbucket_recurring_outages/) and still seems to be happening intermittently.

The problem with these is that whatever response Bitbucket is returning (seems often be a 500 server error followed by HTML content) is not being handled well by the pull request builder with the result being that we get a rash of new builds for all of our open PRs even though none of the branches associated with them have changed.

It has been difficult to dig thru Jenkins logs whenever this happens as the (HTML) content coming back from Bitbucket keeps getting logged entirely so our Jenkins log is polluted with all sorts of stuff. If there is a specific string I should look for to help debug this I can try to dig that out.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/nishio-dens/bitbucket-pullrequest-builder-plugin/issues/214?email_source=notifications&email_token=AAA72VRI4ZAPEJ5ENEFZVXLQNCEVJA5CNFSM4I5XTZE2YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4HP2RXEQ, or mute the thread https://github.com/notifications/unsubscribe-auth/AAA72VROOOPMSGHPSPBXKIDQNCEVJANCNFSM4I5XTZEQ .