search

nishio-dens / bitbucket-pullrequest-builder-plugin

Bitbucket Pull Request Builder Plugin for Jenkins
Other
125 stars 145 forks source link

Build links not displayed on BitBucket Server 7.0+ #223

Closed rmichalak closed 4 years ago

rmichalak commented 4 years ago

Build links are not displayed on BitBucket Server, as per attached screenshot: image

It seems that 'name' and 'description' are missing from requests (which is not the case for BitBucket Cloud) Proposed fix is to align request with Cloud version: https://github.com/rmichalak/bitbucket-pullrequest-builder-plugin/commit/09a67c4f3a2cfe4a0f4d5d9f6f5585687e48834f although I'm not sure if it won't break anything for older BitBucket Server versions.

rmichalak commented 4 years ago

More info: The problem only exists when reviewing particular pull request, not on a list of all pull requests. In both cases BitBucket returns the same response but 'key' is only used to display a link on a list of PRs. The problem is reported (and fixed) here https://jira.atlassian.com/browse/BSERV-12350, nevertheless I think it still would be good to include 'name' and 'description' in updates, to line it up with the cloud version.

CodeMonk commented 4 years ago

Sorry - only one person that I know of is using / supporting the server side, so, bugs there are completely normal :(

The fix looked good to me at first glance, please put up a PR to nishio-dens' repo, and I'll merge ASAP!

-Dave

On Tue, May 26, 2020 at 7:02 AM Robert Michalak notifications@github.com wrote:

Build links are not displayed on BitBucket Server, as per attached screenshot: [image: image] https://user-images.githubusercontent.com/8317772/82903389-2800b300-9f61-11ea-8d5a-af0d8a4023e8.png

It seems that 'name' and 'description' are missing from requests (which is not the case for BitBucket Cloud) Proposed fix is to align request with Cloud version: rmichalak@09a67c4 https://github.com/rmichalak/bitbucket-pullrequest-builder-plugin/commit/09a67c4f3a2cfe4a0f4d5d9f6f5585687e48834f although I'm not sure if it won't break anything for older BitBucket Server version.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/nishio-dens/bitbucket-pullrequest-builder-plugin/issues/223, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAA72VURDVPUWMUAPJJ2N33RTO4XHANCNFSM4NKJGA7A .

rmichalak commented 4 years ago

No worries, I'm here to help ;) Patched version works in our infrastructure without any problems for over two weeks now.

CodeMonk commented 4 years ago

Merged - will be in next release.