search

nishtahir / language-kotlin

Textmate language grammar for the Kotlin programming language
Apache License 2.0
12 stars 6 forks source link

Unsigned types added #25

Closed starsep closed 4 years ago

starsep commented 4 years ago

Fixes nishtahir/language-kotlin#24

I just added types to src/types.YAML-tmLanguage Then run npm run build, npm run format and npm test and everything seems fine.

Should I do anything else? Add some additional test cases?

nishtahir commented 4 years ago

Thanks for the contribution @starsep it would be nice to add tests for this to make sure that the scope support.class.kotlin is added correctly.

This can be a reference https://github.com/nishtahir/language-kotlin/blob/e99f761e2e44ffc5e17cb2642acb6a6238bad7b4/test/Types.test.kt#L3-L18

but it would be something like 

val test: UInt
          ^^^^ support.class.kotlin