nishtahir / language-kotlin

Textmate language grammar for the Kotlin programming language

Apache License 2.0

12 stars 6 forks source link

Addresses double-quote in character issue from issue #26. #34

Closed shaeberling closed 3 years ago

shaeberling commented 3 years ago

Uses a negative lookahead regex to ensure that no single quote is allowed on either side of the double-quote.

Verified using Lightshow on the following source: https://github.com/shaeberling/euler/blob/master/kotlin/src/com/s13g/aoc/aoc2020/Day19.kt

Also added a regression test case that will fail without this change.

codecov[bot] commented 3 years ago

Codecov Report

Merging #34 (2ed8747) into master (89d2d5e) will not change coverage. The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master      #34   +/-   ##
=======================================
  Coverage   67.47%   67.47%           
=======================================
  Files          12       12           
  Lines         455      455           
=======================================
  Hits          307      307           
  Misses        148      148

Impacted Files	Coverage Δ
src/literals.YAML-tmLanguage	`100.00% <100.00%> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 89d2d5e...2ed8747. Read the comment docs.

nishtahir commented 3 years ago

Thanks for your contribution 🎉. This looks really good. Would you mind adding a similar test to https://github.com/nishtahir/language-kotlin/blob/master/test/literals.test.kt? It would also be really nice to add a test case to the regression test that makes sure that scopes we don't want are not included. You can do this with the - symbol as used in this example https://github.com/nishtahir/language-kotlin/blob/89d2d5e185e9674bdf4b9e25c50be01842696af7/test/regression/19.test.kt#L6

shaeberling commented 3 years ago

No problem, let me know how this looks.