search

nishtahir / language-kotlin

Textmate language grammar for the Kotlin programming language
Apache License 2.0
12 stars 6 forks source link

Fixes generic recognition and parsing even in deep nested conditions properly, and fixes unintended stoppage on parsing the inheritence part (after colon). #41

Closed Animeshz closed 3 years ago

Animeshz commented 3 years ago

Fixes #19 and #40.

Before:

Screenshot 2021-02-07 191743

After:

Screenshot 2021-02-07 191822

codecov[bot] commented 3 years ago

Codecov Report

Merging #41 (ac48d3a) into master (e2b7595) will increase coverage by 0.79%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #41      +/-   ##
==========================================
+ Coverage   68.30%   69.10%   +0.79%     
==========================================
  Files          12       13       +1     
  Lines         467      479      +12     
==========================================
+ Hits          319      331      +12     
  Misses        148      148
Impacted Files Coverage Δ
src/types.YAML-tmLanguage 33.33% <ø> (ø)
src/classes.YAML-tmLanguage 100.00% <100.00%> (ø)
src/functions.YAML-tmLanguage 100.00% <100.00%> (ø)
src/generic.YAML-tmLanguage 100.00% <100.00%> (ø)
src/ident.YAML-tmLanguage 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update e2b7595...ac48d3a. Read the comment docs.

Animeshz commented 3 years ago

This includes changes of #39 so it (39) can be safely ignored!

nishtahir commented 3 years ago

LGTM. Thank you for your contribution 🎉