nishtahir / language-kotlin

Textmate language grammar for the Kotlin programming language
Apache License 2.0
12 stars 6 forks source link

Use storage scope for annotations's text part and improve annotation regex. #43

Open Animeshz opened 3 years ago

Animeshz commented 3 years ago

Fixes #42 by merging use-site annotation regex with one without use-site.

Also moves the scope of the meta.annotation.kotlin to storage.type.annotation.kotlin for the name of the annotation (excluding the braces).

codecov[bot] commented 3 years ago

Codecov Report

Merging #43 (46e2761) into master (5738095) will increase coverage by 0.74%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #43      +/-   ##
==========================================
+ Coverage   69.23%   69.97%   +0.74%     
==========================================
  Files          13       13              
  Lines         481      493      +12     
==========================================
+ Hits          333      345      +12     
  Misses        148      148              
Impacted Files Coverage Δ
src/ident.YAML-tmLanguage 100.00% <ø> (ø)
src/keywords.YAML-tmLanguage 60.00% <ø> (ø)
src/annotations.YAML-tmLanguage 100.00% <100.00%> (ø)
src/generic.YAML-tmLanguage 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 5738095...46e2761. Read the comment docs.

Animeshz commented 3 years ago

Oops closed by mistake, did not knew master is up on a PR.