Closed qhy040404 closed 1 year ago
This change looks good however it's missing tests around the scopes (see the Testing section of the README). Would you mind adding tests for it? This is the file that would need to be updated https://github.com/nishtahir/language-kotlin/blob/master/test/Keywords.test.kt. You can update the corpus in the snapshot folder to include the keyword then run npm run snapshot
to generate and inspect the scopes
I don't know whether it's ok. @nishtahir review request
Base: 70.37% // Head: 70.37% // No change to project coverage :thumbsup:
Coverage data is based on head (
dec06c8
) compared to base (0bbb091
). Patch coverage: 100.00% of modified lines in pull request are covered.
:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
Looks great. I made a small change to the regression test syntax. Thank you for your contribution :tada:
Thanks! 😄
Support
inner
keyword.A nested class marked as inner can access the members of its outer class. Inner classes carry a reference to an object of an outer class: