search

nismod / open-gira

Open-data Global Infrastructure Risk/Resilience Analysis
https://nismod.github.io/open-gira/
MIT License
12 stars 3 forks source link

Lift requirements into environment.yml explicitly #94

Closed tomalrussell closed 1 year ago

tomalrussell commented 2 years ago

Should help micromamba build the env, as it didn't handle the -r requirements.txt reference for pip.

thomas-fred commented 2 years ago

Delete the requirements.txt too?

tomalrussell commented 2 years ago

Can you reproduce the test failure locally? I'll try on a linux machine when possible - the failure is in the image comparison test for make_exposure_img.

tomalrussell commented 2 years ago

Looks like a minor difference in font rendering:

Actual

actual

Expected

expected

thomas-fred commented 2 years ago

Hmm, yeah it is the text rendering isn't it. So the images are different...

Matplotlib is pinned, but perhaps actual and expected were generated with different backends.

Oh the complexities of comparing plotted output from multiple machines.

thomas-fred commented 2 years ago

I'm setting up open-gira on virtualised Ubuntu 20.04, will give it a go locally in a moment.

thomas-fred commented 2 years ago

Yeah it fails locally for me too.

thomas-fred commented 2 years ago

So I suppose some of the packages that conda is now installing directly rather than delegating to pip are different. I was wondering about something like Pillow that's pretty low level, does text rendering for images.

thomas-fred commented 2 years ago

If it's failing everywhere, but it's only a text difference, perhaps just update the image -- I have no great desire to delve deeper.