search

nismod / smif

Simulation Modelling Integration Framework
http://www.itrc.org.uk
MIT License
22 stars 6 forks source link

Removed reporting of coordinates - too verbose for error #217

Closed willu47 closed 6 years ago

willu47 commented 6 years ago

@tomalrussell - please confirm this is okay:

I have removed reporting of mismatched coordinates as these are a function of dimensions?

Or, is there a case where we need to compare coordinates that have different dimension names?

tomalrussell commented 6 years ago

This looks fine - I think we do need to check that coords match, as you have it in 107482e, unless we can guarantee that a dimension name is used uniquely to describe one set of coordinates.