Closed RoaldL closed 6 years ago
Merging #232 into develop will decrease coverage by
1.7%
. The diff coverage is61.74%
.
@@ Coverage Diff @@
## develop #232 +/- ##
===========================================
- Coverage 83.08% 81.37% -1.71%
===========================================
Files 50 52 +2
Lines 3771 4531 +760
Branches 454 684 +230
===========================================
+ Hits 3133 3687 +554
- Misses 572 750 +178
- Partials 66 94 +28
Flag | Coverage Δ | |
---|---|---|
#javascript | 81.37% <61.74%> (-1.71%) |
:arrow_down: |
#python | 86.9% <67.64%> (-2.96%) |
:arrow_down: |
Impacted Files | Coverage Δ | |
---|---|---|
src/smif/data_layer/data_interface.py | 96.91% <ø> (+1.16%) |
:arrow_up: |
...pp/src/components/ConfigForm/SosModelConfigForm.js | 15.21% <0%> (-6%) |
:arrow_down: |
src/smif/exception.py | 100% <100%> (ø) |
:arrow_up: |
src/smif/data_layer/datafile_interface.py | 86.84% <55.55%> (+1.05%) |
:arrow_up: |
src/smif/http_api/crud.py | 89.78% <65.78%> (-4.88%) |
:arrow_down: |
src/smif/data_layer/validate.py | 31.68% <67.85%> (-68.32%) |
:arrow_down: |
src/smif/metadata/spec.py | 99.15% <0%> (-0.85%) |
:arrow_down: |
src/smif/data_layer/memory_interface.py | 95.91% <0%> (-0.32%) |
:arrow_down: |
src/smif/model/model.py | 100% <0%> (ø) |
:arrow_up: |
... and 13 more |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 675f76b...5ab33c3. Read the comment docs.
This pull request suggests a system to allow validation in the user-interface. The idea is to design validation methods that can both be used to validate the smif config during runtime and when the datainterface is used to write/update configurations.