nismod / smif

Simulation Modelling Integration Framework
http://www.itrc.org.uk
MIT License
22 stars 6 forks source link

Feature/dataarray #237

Closed willu47 closed 6 years ago

willu47 commented 6 years ago

A DataArray is a thin wrapper class around:

It provides a convenient bundle of data and metadata which saves on numerous duplicate calls to obtain the Spec of an input, output and parameter, particularly for methods on the DataHandle, such as get_data, get_parameter and get_results and corresponding methods on the DataInterface. As such, all methods that previously returned data, now return a DataArray allowing operations on the data to be completed without a separate call to obtain the data Spec.

This work highlighted a few issues:

To do:

codecov[bot] commented 6 years ago

Codecov Report

Merging #237 into develop will increase coverage by 0.1%. The diff coverage is 82.58%.

Impacted file tree graph

@@            Coverage Diff             @@
##           develop     #237     +/-   ##
==========================================
+ Coverage    78.04%   78.14%   +0.1%     
==========================================
  Files           50       51      +1     
  Lines         3939     4036     +97     
  Branches       498      510     +12     
==========================================
+ Hits          3074     3154     +80     
- Misses         778      791     +13     
- Partials        87       91      +4
Flag Coverage Δ
#javascript 78.14% <82.58%> (+0.1%) :arrow_up:
#python 83.93% <82.58%> (-0.05%) :arrow_down:
Impacted Files Coverage Δ
src/smif/data_layer/database_interface.py 100% <100%> (ø) :arrow_up:
src/smif/data_layer/memory_interface.py 96.29% <100%> (+0.18%) :arrow_up:
src/smif/model/model.py 100% <100%> (ø) :arrow_up:
src/smif/data_layer/data_array.py 75.75% <75.75%> (ø)
src/smif/data_layer/data_handle.py 82.23% <76.47%> (-2.11%) :arrow_down:
src/smif/data_layer/datafile_interface.py 84.9% <83.33%> (+1.05%) :arrow_up:
src/smif/data_layer/data_interface.py 93.9% <85.71%> (-2.93%) :arrow_down:
src/smif/metadata/coordinates.py 97.05% <0%> (-2.95%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 24c66a8...7595535. Read the comment docs.