search

nismod / smif

Simulation Modelling Integration Framework
http://www.itrc.org.uk
MIT License
22 stars 6 forks source link

Add context to error when reading parameter defaults #248

Closed tomalrussell closed 5 years ago

tomalrussell commented 5 years ago

Re-raise SmifDataMismatchError with "Reading default parameter values for {sector_model}:{parameter}"

codecov[bot] commented 5 years ago

Codecov Report

Merging #248 into master will increase coverage by 0.01%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #248      +/-   ##
==========================================
+ Coverage   75.47%   75.48%   +0.01%     
==========================================
  Files          52       52              
  Lines        4232     4235       +3     
  Branches      513      513              
==========================================
+ Hits         3194     3197       +3     
  Misses        951      951              
  Partials       87       87
Flag Coverage Δ
#javascript 75.48% <100%> (+0.01%) :arrow_up:
#python 83.77% <100%> (+0.01%) :arrow_up:
Impacted Files Coverage Δ
src/smif/data_layer/datafile_interface.py 85.37% <100%> (+0.06%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 3a5e4d2...89a78c2. Read the comment docs.

willu47 commented 5 years ago

Thanks @tomalrussell - could you add a test to demonstrate expected behaviour?