Closed RoaldL closed 5 years ago
The click-through functionality works very well, but I've noticed a few issues with the tables (which are otherwise very useful).
10 rows
and then 5 rows
to display just five.Suggestions
Fix browser history after navigate Look into history.push
In use dropdown should show a little hand Add link to Job from SosModelRun
Merging #255 into master will decrease coverage by
0.11%
. The diff coverage is22.22%
.
@@ Coverage Diff @@
## master #255 +/- ##
==========================================
- Coverage 73.78% 73.66% -0.12%
==========================================
Files 52 52
Lines 4329 4337 +8
Branches 521 521
==========================================
+ Hits 3194 3195 +1
- Misses 1045 1052 +7
Partials 90 90
Flag | Coverage Δ | |
---|---|---|
#javascript | 73.66% <22.22%> (-0.12%) |
:arrow_down: |
#python | 83.95% <ø> (ø) |
:arrow_up: |
Impacted Files | Coverage Δ | |
---|---|---|
...pp/src/components/ConfigForm/SosModelConfigForm.js | 13.79% <0%> (-0.76%) |
:arrow_down: |
...src/components/ConfigForm/SectorModelConfigForm.js | 18.91% <0%> (-1.67%) |
:arrow_down: |
...mif/app/src/components/Simulation/ConfigSummary.js | 100% <100%> (ø) |
:arrow_up: |
...pp/src/components/ConfigForm/ModelRunConfigForm.js | 7.6% <50%> (+0.94%) |
:arrow_up: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 999b785...b9a82c7. Read the comment docs.
This pull request adds links to SosModel, Sector Model and Scenario configuration, to provide one-click access to configurations that hold a reference to the configuration that is open.
Story: https://www.pivotaltracker.com/story/show/161646199