Closed willu47 closed 5 years ago
Merging #257 into master will decrease coverage by
0.05%
. The diff coverage is50%
.
@@ Coverage Diff @@
## master #257 +/- ##
==========================================
- Coverage 73.74% 73.68% -0.06%
==========================================
Files 52 52
Lines 4292 4302 +10
Branches 518 521 +3
==========================================
+ Hits 3165 3170 +5
- Misses 1038 1042 +4
- Partials 89 90 +1
Flag | Coverage Δ | |
---|---|---|
#javascript | 73.68% <50%> (-0.06%) |
:arrow_down: |
#python | 83.85% <50%> (-0.08%) |
:arrow_down: |
Impacted Files | Coverage Δ | |
---|---|---|
src/smif/data_layer/datafile_interface.py | 84.68% <50%> (-0.41%) |
:arrow_down: |
...pp/src/components/ConfigForm/ModelRunConfigForm.js | 6.66% <0%> (-0.08%) |
:arrow_down: |
src/smif/data_layer/memory_interface.py | 87.75% <0%> (+0.12%) |
:arrow_up: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 3546ce1...d208278. Read the comment docs.
Fixes 161648445
Probably want to move folder creation into the DataFileInterface, but add an "initialize" method to the DataInterface to setup a new smif project whatever the interface.