nismod / smif

Simulation Modelling Integration Framework
http://www.itrc.org.uk
MIT License
22 stars 6 forks source link

Pass path to binary filestore, extract method to parent class #293

Closed willu47 closed 5 years ago

willu47 commented 5 years ago

Fixes binary filestore #162733922

Problem manifested itself as inability to read in interventions (stored in a csv file) or default parameter values (also stored in csv), but these use to general functions implemented in ParquetFileStore to expect Parquet files.

codecov[bot] commented 5 years ago

Codecov Report

Merging #293 into master will increase coverage by 0.05%. The diff coverage is 92.85%.

Impacted file tree graph

@@           Coverage Diff            @@
##           master   #293      +/-   ##
========================================
+ Coverage   68.95%    69%   +0.05%     
========================================
  Files          58     58              
  Lines        4906   4908       +2     
  Branches      595    592       -3     
========================================
+ Hits         3383   3387       +4     
+ Misses       1427   1426       -1     
+ Partials       96     95       -1
Flag Coverage Δ
#javascript 69% <92.85%> (+0.05%) :arrow_up:
#python 77.01% <92.85%> (+0.05%) :arrow_up:
Impacted Files Coverage Δ
src/smif/data_layer/store.py 94.61% <100%> (ø) :arrow_up:
src/smif/data_layer/file/__init__.py 100% <100%> (ø) :arrow_up:
src/smif/data_layer/file/file_data_store.py 86.06% <91.66%> (+0.79%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update bbaa84f...c24fcfc. Read the comment docs.