nismod / smif

Simulation Modelling Integration Framework
http://www.itrc.org.uk
MIT License
22 stars 6 forks source link

Built in adaptors call ndim on DataArray #317

Closed willu47 closed 5 years ago

willu47 commented 5 years ago

This causes the following error:

AttributeError: 'DataArray' object has no attribute 'ndim'

Reported by @LahiruJayasuriya

The problem is caused by Adaptor.simulate passing a DataArray to Adaptor.convert where convert is expecting an ndarray.

Need to fix the tests, which currently pass in numpy ndarray rather than smif DataArray objects.

tomalrussell commented 5 years ago

Closed by #318