nismod / smif

Simulation Modelling Integration Framework
http://www.itrc.org.uk
MIT License
22 stars 6 forks source link

Feature/data array save #323

Closed tomalrussell closed 5 years ago

tomalrussell commented 5 years ago

Merge after #322

This contains small speed/size improvements arising from nismod/nismod2#60:

codecov[bot] commented 5 years ago

Codecov Report

Merging #323 into master will increase coverage by 0.05%. The diff coverage is 95.23%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #323      +/-   ##
==========================================
+ Coverage   69.75%   69.81%   +0.05%     
==========================================
  Files          59       59              
  Lines        5045     5055      +10     
  Branches      605      605              
==========================================
+ Hits         3519     3529      +10     
  Misses       1431     1431              
  Partials       95       95
Flag Coverage Δ
#javascript 69.81% <95.23%> (+0.05%) :arrow_up:
#python 77.79% <95.23%> (+0.05%) :arrow_up:
Impacted Files Coverage Δ
src/smif/data_layer/file/file_data_store.py 86.85% <100%> (ø) :arrow_up:
src/smif/metadata/spec.py 99.1% <100%> (+0.01%) :arrow_up:
src/smif/data_layer/data_handle.py 83.05% <100%> (+0.44%) :arrow_up:
src/smif/data_layer/data_array.py 83.87% <85.71%> (+0.26%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update e0ac8e3...1e06f40. Read the comment docs.

willu47 commented 5 years ago

Should this merge into master or onto a develop branch ready for next release?