search

nismod / smif

Simulation Modelling Integration Framework
http://www.itrc.org.uk
MIT License
22 stars 6 forks source link

Fix/data read errors #324

Closed tomalrussell closed 5 years ago

tomalrussell commented 5 years ago

Aiming for improved error messages in data reading (cases in #301, #312, #320)

Most of the handling can be done in the DataArray.from_df method, which should avoid duplication of similar validation/error-handling code.

codecov[bot] commented 5 years ago

Codecov Report

Merging #324 into master will increase coverage by 0.11%. The diff coverage is 95.83%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #324      +/-   ##
==========================================
+ Coverage   69.81%   69.93%   +0.11%     
==========================================
  Files          59       59              
  Lines        5055     5075      +20     
  Branches      605      608       +3     
==========================================
+ Hits         3529     3549      +20     
  Misses       1431     1431              
  Partials       95       95
Flag Coverage Δ
#javascript 69.93% <95.83%> (+0.11%) :arrow_up:
#python 77.9% <95.83%> (+0.1%) :arrow_up:
Impacted Files Coverage Δ
src/smif/metadata/coordinates.py 97.22% <ø> (ø) :arrow_up:
src/smif/data_layer/file/file_data_store.py 86.8% <100%> (-0.05%) :arrow_down:
src/smif/data_layer/data_array.py 86.2% <95.12%> (+2.33%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 13cbb39...ec95a61. Read the comment docs.