tomalrussell commented 5 years ago

Changes read/write coefficients everywhere to use to/from dimension names instead of Spec, making clear the assumption that coefficients are calculated and used a dimension-pair-at-a-time.

Closes #314

codecov[bot] commented 5 years ago

Codecov Report

Merging #325 into master will not change coverage. The diff coverage is 100%.

@@           Coverage Diff           @@
##           master     #325   +/-   ##
=======================================
  Coverage   69.93%   69.93%           
=======================================
  Files          59       59           
  Lines        5075     5075           
  Branches      608      608           
=======================================
  Hits         3549     3549           
  Misses       1431     1431           
  Partials       95       95

Flag	Coverage Δ
#javascript	`69.93% <100%> (ø)`	:arrow_up:
#python	`77.9% <100%> (ø)`	:arrow_up:

Impacted Files	Coverage Δ
src/smif/data_layer/abstract_data_store.py	`100% <ø> (ø)`	:arrow_up:
src/smif/data_layer/store.py	`94.75% <100%> (ø)`	:arrow_up:
src/smif/convert/adaptor.py	`90% <100%> (+0.16%)`	:arrow_up:
src/smif/data_layer/data_handle.py	`83.05% <100%> (ø)`	:arrow_up:
src/smif/data_layer/file/file_data_store.py	`86.8% <100%> (ø)`	:arrow_up:
src/smif/data_layer/database_interface.py	`16.58% <100%> (ø)`	:arrow_up:
src/smif/data_layer/memory_interface.py	`88.11% <100%> (-0.05%)`	:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 5e0e04b...6002bcf. Read the comment docs.

tomalrussell commented 5 years ago

The Travis CI tests are failing, with a familiar error - maybe fixed by #324?

I'll try rebasing first, looks like Travis managed to pick up gdal/libgdal from main not conda-forge.

nismod / smif

Feature/coefficients by dim #325

Codecov Report