search

nismod / smif

Simulation Modelling Integration Framework
http://www.itrc.org.uk
MIT License
22 stars 6 forks source link

Fix/store intervals #326

Closed tomalrussell closed 5 years ago

tomalrussell commented 5 years ago

Store dimension definitions as CSV, special-case and test using interval definitions (nested lists).

Part of the work on nismod/nismod2#63

codecov[bot] commented 5 years ago

Codecov Report

Merging #326 into master will increase coverage by 0.31%. The diff coverage is 90.83%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #326      +/-   ##
==========================================
+ Coverage   69.93%   70.24%   +0.31%     
==========================================
  Files          59       59              
  Lines        5075     5115      +40     
  Branches      608      610       +2     
==========================================
+ Hits         3549     3593      +44     
+ Misses       1431     1429       -2     
+ Partials       95       93       -2
Flag Coverage Δ
#javascript 70.24% <90.83%> (+0.31%) :arrow_up:
#python 78.19% <90.83%> (+0.29%) :arrow_up:
Impacted Files Coverage Δ
src/smif/model/sector_model.py 100% <ø> (ø) :arrow_up:
src/smif/data_layer/file/file_data_store.py 86.8% <100%> (ø) :arrow_up:
src/smif/data_layer/store.py 94.78% <100%> (+0.02%) :arrow_up:
src/smif/data_layer/data_handle.py 83.33% <100%> (+0.28%) :arrow_up:
src/smif/convert/interval.py 98.33% <100%> (ø) :arrow_up:
src/smif/data_layer/data_array.py 86.2% <100%> (ø) :arrow_up:
src/smif/convert/region.py 87.5% <100%> (+0.17%) :arrow_up:
src/smif/convert/adaptor.py 90% <100%> (ø) :arrow_up:
src/smif/data_layer/file/file_config_store.py 83.77% <100%> (ø) :arrow_up:
src/smif/convert/unit.py 56.25% <100%> (ø) :arrow_up:
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 20017f4...e74ffd4. Read the comment docs.