search

nismod / smif

Simulation Modelling Integration Framework
http://www.itrc.org.uk
MIT License
22 stars 6 forks source link

Closes Issue #334 #336

Closed willu47 closed 5 years ago

willu47 commented 5 years ago

Adds a get state method to the ResultsHandle class and typing to a bit more of the DataHandle, Store and MetaData modules.

codecov[bot] commented 5 years ago

Codecov Report

Merging #336 into master will increase coverage by 0.09%. The diff coverage is 96.87%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #336      +/-   ##
==========================================
+ Coverage   70.34%   70.43%   +0.09%     
==========================================
  Files          59       59              
  Lines        5119     5135      +16     
  Branches      608      608              
==========================================
+ Hits         3601     3617      +16     
  Misses       1426     1426              
  Partials       92       92
Flag Coverage Δ
#javascript 70.43% <96.87%> (+0.09%) :arrow_up:
#python 78.39% <96.87%> (+0.08%) :arrow_up:
Impacted Files Coverage Δ
src/smif/data_layer/abstract_data_store.py 100% <100%> (ø) :arrow_up:
src/smif/data_layer/store.py 94.84% <100%> (+0.06%) :arrow_up:
src/smif/metadata/timestep.py 100% <100%> (ø) :arrow_up:
src/smif/data_layer/abstract_metadata_store.py 100% <100%> (ø) :arrow_up:
src/smif/data_layer/data_handle.py 84% <92.85%> (+0.52%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update ba2627e...8e807db. Read the comment docs.

willu47 commented 5 years ago

@tomalrussell - ready for re-review