search

nismod / smif

Simulation Modelling Integration Framework
http://www.itrc.org.uk
MIT License
22 stars 6 forks source link

Catch narrative config errors in store #344

Closed willu47 closed 5 years ago

willu47 commented 5 years ago

Closes #342

Unsure as to whether store.py is the best location for these error messages. These types of issues should be caught in configuration validation (see also #343).

codecov[bot] commented 5 years ago

Codecov Report

Merging #344 into master will increase coverage by 0.07%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #344      +/-   ##
==========================================
+ Coverage   70.34%   70.41%   +0.07%     
==========================================
  Files          59       59              
  Lines        5119     5125       +6     
  Branches      608      610       +2     
==========================================
+ Hits         3601     3609       +8     
+ Misses       1426     1425       -1     
+ Partials       92       91       -1
Flag Coverage Δ
#javascript 70.41% <100%> (+0.07%) :arrow_up:
#python 78.38% <100%> (+0.07%) :arrow_up:
Impacted Files Coverage Δ
src/smif/data_layer/store.py 95.76% <100%> (+0.98%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 17aab98...0f79e0c. Read the comment docs.