nismod / smif

Simulation Modelling Integration Framework
http://www.itrc.org.uk
MIT License
22 stars 6 forks source link

Parent issue for results API #350

Closed fcooper8472 closed 5 years ago

fcooper8472 commented 5 years ago

Goal

Improve the ability to query results from model runs within smif by developing a suitable API.

Problem

Core functionality

modelruns: ['first_model_run', 'test_model_run', 'ensemble_0000', 'ensemble_0001', 'ensemble_0002']
timesteps: [2010, 2015, 2020]
iterations: [0]

models

name: 'water_supply'
outputs:
- name: cost
  dims:
  - local_authority_districts
  dtype: float
  unit: million GBP
- name: energy_demand
  dims:
  - local_authority_districts
  dtype: float
  unit: kWh

Something like:

fcooper8472 commented 5 years ago

@willu47 question about the proposed get_results behaviour:

Let's say I supply models=['water_supply'], but water_supply is run in a number of different model runs... are you thinking that get_results only gets results for a specific model run?

willu47 commented 5 years ago

We need both cases - we should add model run as a result dimension above. However... it does not make sense to compare results from model runs that contain a different system-of-systems, where a model can exist in multiple system-of-systems.

fcooper8472 commented 5 years ago

Closed by #367