nismod / smif

Simulation Modelling Integration Framework
http://www.itrc.org.uk
MIT License
22 stars 6 forks source link

Check that the results for a model run are complete, and if not, which are missing #352

Closed willu47 closed 5 years ago

willu47 commented 5 years ago

Add a function to the smif.data_layer.store.Store class which:

Parent issue #350

fcooper8472 commented 5 years ago

@willu47 just checking, by smif.data_handle.store.Store you mean smif.data_layer.store.Store?

fcooper8472 commented 5 years ago

This overlaps quite a lot with #351: work on #351 implemented canonical_expected_results and canonical_available_results, which are the expected and available results with all decision iterations collapsed down to 0.

The reason for collapsing the decision iterations is that it is impossible to know (given the configuration) which output time steps will match to which decision iterations, so we simply have to ensure each time step exists in the output.

For this issue I propose a new method canonical_missing_results such that

store.canonical_missing_results('name') + store.canonical_available_results('name') == store.canonical_expected_results('name')
fcooper8472 commented 5 years ago

This is now implemented, inc cli functionality and tests. I'll open a PR.

fcooper8472 commented 5 years ago

Closed by #360