nismod / smif

Simulation Modelling Integration Framework
http://www.itrc.org.uk
MIT License
22 stars 6 forks source link

Results api #374

Closed fcooper8472 closed 5 years ago

fcooper8472 commented 5 years ago

See #372

codecov[bot] commented 5 years ago

Codecov Report

Merging #374 into develop will increase coverage by 0.08%. The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #374      +/-   ##
===========================================
+ Coverage    71.09%   71.18%   +0.08%     
===========================================
  Files           60       60              
  Lines         5342     5351       +9     
  Branches       661      663       +2     
===========================================
+ Hits          3798     3809      +11     
+ Misses        1448     1446       -2     
  Partials        96       96
Flag Coverage Δ
#javascript 71.18% <100%> (+0.08%) :arrow_up:
#python 78.89% <100%> (+0.08%) :arrow_up:
Impacted Files Coverage Δ
src/smif/data_layer/results.py 92.64% <100%> (+1.12%) :arrow_up:
src/smif/data_layer/memory_interface.py 88.81% <0%> (+0.69%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 5c1d790...63a7769. Read the comment docs.

willu47 commented 5 years ago

Hi @fcooper8472 - yes, great, happy with this. Note that currently the results.available_results() method doesn't list scenarios within the big dictionary. Could you add it in for completeness? Then happy for a merge into develop (and then a quick release following the next step - to add read scenario to the results API).

fcooper8472 commented 5 years ago

and then a quick release following the next step - to add read scenario to the results API

Just to clarify, "read scenario" is the method to read scenario variant data?

willu47 commented 5 years ago

Yep, noted by @tlestang in #373