search

nismod / smif

Simulation Modelling Integration Framework
http://www.itrc.org.uk
MIT License
22 stars 6 forks source link

Proposed fix for bug #378 #379

Closed willu47 closed 5 years ago

willu47 commented 5 years ago

Reorder timestep in spec to match that read directly from the data to fix #378

codecov[bot] commented 5 years ago

Codecov Report

Merging #379 into develop will not change coverage. The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #379   +/-   ##
========================================
  Coverage    71.28%   71.28%           
========================================
  Files           60       60           
  Lines         5370     5370           
  Branches       664      664           
========================================
  Hits          3828     3828           
  Misses        1446     1446           
  Partials        96       96
Flag Coverage Δ
#javascript 71.28% <100%> (ø) :arrow_up:
#python 78.97% <100%> (ø) :arrow_up:
Impacted Files Coverage Δ
src/smif/data_layer/store.py 91.61% <100%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update f135008...ca72aa4. Read the comment docs.

tlestang commented 5 years ago

I'm then surprised that it works fine for the get_results method (store.get_results_darray_internal()) . I'll do the math again tomorrow :)