codecov[bot]
commented
5 years ago Codecov Report
Merging #382 into master will decrease coverage by
1.2%. The diff coverage is43.68%.
@@ Coverage Diff @@
## master #382 +/- ##
==========================================
- Coverage 71.94% 70.73% -1.21%
==========================================
Files 60 63 +3
Lines 5510 5649 +139
Branches 693 716 +23
==========================================
+ Hits 3964 3996 +32
- Misses 1447 1549 +102
- Partials 99 104 +5| Flag | Coverage Δ | |
|---|---|---|
| #javascript | 70.73% <43.68%> (-1.21%) |
:arrow_down: |
| #python | 77.89% <43.68%> (-1.63%) |
:arrow_down: |
| Impacted Files | Coverage Δ | |
|---|---|---|
| src/smif/controller/modelschedulers/__init__.py | 100% <100%> (ø) |
|
| src/smif/controller/jobscheduler.py | 100% <100%> (ø) |
|
| src/smif/controller/modelrun.py | 91.52% <100%> (ø) |
:arrow_up: |
| .../smif/controller/modelschedulers/dafnischeduler.py | 19.69% <19.69%> (ø) |
|
| ...mif/controller/modelschedulers/defaultscheduler.py | 76.74% <50%> (ø) |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing dataPowered by Codecov. Last update 21b5235...f66236e. Read the comment docs.
roseDickinson
JobScheduler has been moved out into its own file.
Added -s/--scheduler argument to allow picking between schedulers. Default value is the default scheduler. When DAFNI scheduler is selected added arguments -u/--username and -pw/--password to allow logging into the DAFNI job submission API. This scheduler only works on the VPN at RAL and currently doesn't have full functionality so shouldn't be used for now.
Increased the rendering interval as this was causing the UI to jitter and the model runs occasionally disappear.