search

nismod / smif

Simulation Modelling Integration Framework
http://www.itrc.org.uk
MIT License
22 stars 6 forks source link

Handle case when a spec is missing dims #394

Closed tomalrussell closed 5 years ago

tomalrussell commented 5 years ago

Closes #331

Manifested as an error in saving SoSModel through the app

_validate_dependencies assumed 'dims' would be present on any spec and threw a KeyError when trying to access.

codecov[bot] commented 5 years ago

Codecov Report

Merging #394 into master will decrease coverage by <.01%. The diff coverage is 80%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #394      +/-   ##
==========================================
- Coverage   70.79%   70.78%   -0.01%     
==========================================
  Files          64       64              
  Lines        5714     5717       +3     
  Branches      728      730       +2     
==========================================
+ Hits         4045     4047       +2     
  Misses       1563     1563              
- Partials      106      107       +1
Flag Coverage Δ
#javascript 70.78% <80%> (-0.01%) :arrow_down:
#python 77.85% <80%> (-0.01%) :arrow_down:
Impacted Files Coverage Δ
src/smif/data_layer/validate.py 47.47% <80%> (+0.19%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 3630652...1793265. Read the comment docs.