Closed tomalrussell closed 5 years ago
Merging #394 into master will decrease coverage by
<.01%
. The diff coverage is80%
.
@@ Coverage Diff @@
## master #394 +/- ##
==========================================
- Coverage 70.79% 70.78% -0.01%
==========================================
Files 64 64
Lines 5714 5717 +3
Branches 728 730 +2
==========================================
+ Hits 4045 4047 +2
Misses 1563 1563
- Partials 106 107 +1
Flag | Coverage Δ | |
---|---|---|
#javascript | 70.78% <80%> (-0.01%) |
:arrow_down: |
#python | 77.85% <80%> (-0.01%) |
:arrow_down: |
Impacted Files | Coverage Δ | |
---|---|---|
src/smif/data_layer/validate.py | 47.47% <80%> (+0.19%) |
:arrow_up: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 3630652...1793265. Read the comment docs.
Closes #331
Manifested as an error in saving SoSModel through the app
_validate_dependencies assumed 'dims' would be present on any spec and threw a KeyError when trying to access.