nismod / ukpopulation

Population and demographics projection module, developed for ITRC/MISTRAL
MIT License
13 stars 7 forks source link

Modify query to handle newly released (2018 based) principal projections from nismod #39

Closed ld-archer closed 4 years ago

ld-archer commented 4 years ago

Since new principal projections have been released, the package downloads an empty tsv file in place of these projections. Query parameters need to be modified to fix this issue. Also a decision needs to be made about whether we continue using 2016 based projections for now. We could move straight on to the 2018 projections, but this could cause downstream errors, e.g. if paths are ever hard-coded.

BenjaminIsaac0111 commented 4 years ago

Could just run with the 2018-2118 data just to see if it works?

ld-archer commented 4 years ago

Doing that now, I'll try the full static microsimulation if the worked_example works. Also when we've made whatever changes we're going to make we need to modify the tests. 4/12 tests fail when we run with 2018-2118.

BenjaminIsaac0111 commented 4 years ago

Received this from NOMIS.

"Dear Benjamin

Thank you for your email, unfortunately when the new projections are released, they replace the existing projections on our website, so unfortunately this is no longer available.

Regards Freda Nomis team"