search

nisnevich / discord-consensus-bot

A Discord bot for a consensus in decentralised organisations (e.g. DAO). Implements a lazy consensus and full consensus models.
MIT License
5 stars 4 forks source link

SQLAlchemy Implementation #3

Closed kiks12 closed 1 year ago

kiks12 commented 1 year ago

Used SQLAlchemy for the database as you said. This is my first time trying a pull request, hope it helps.

nisnevich commented 1 year ago

Hi there! Many thanks for your attention to the project! I'll get back to this next week when I have some time off work. If you could please resolve the conflicts according to the latest changes I'd appreciate. Cheers!

kiks12 commented 1 year ago

HI! I resolved the conflicts already, nice to meet you sir!

nisnevich commented 1 year ago

Thanks so much for the pull request! It really helps, I appreciate.

I wanted to share some notes with you what should be improved in the code. I'll fix it myself after merging because I'll keep going with more changes immediately after, just thought that might be helpful for you to know.

  1. Instead of passing the individual attributes of the row to the add_grant_proposal function, the entire object should be passed according to the definition.
  2. message_id is a separate column, it was added in the recent changes. id is autogenerated.
  3. raw SQL in reactions.py should be changed.
  4. some error handling and tests should be added.

Cheers!

nisnevich commented 1 year ago

Hello @kiks12! As this project is affiliated with the Eco Community and I applied for a grant to fund its development, I would like to express my gratitude for your contributions through the pull request. Would you be open to receiving a token of appreciation in $ECO to your crypto wallet? Please reach me here to confirm, and then we can get in touch by other means.

kiks12 commented 1 year ago

Hi there! I received your emails and I'm open to accept your token of appreciation.

nisnevich commented 1 year ago

@kiks12 just sent you 5000 $ECO. Thanks again for your input.

kiks12 commented 1 year ago

Good Day,

I just checked my wallet and I am writing to confirm that I received the funds. Thank you very much sir!

Have a nice day, Francis

On Fri, 7 Apr 2023 at 21:58, Arseniy Nisnevich @.***> wrote:

@kiks12 https://github.com/kiks12 just sent you 5000 $ECO. Thanks again for your input.

— Reply to this email directly, view it on GitHub https://github.com/nisnevich/eco-discord-consensus-bot/pull/3#issuecomment-1500314003, or unsubscribe https://github.com/notifications/unsubscribe-auth/AS5DCPXQ7JG6RH7PXVROBULXAAMQJANCNFSM6AAAAAAT36EWZY . You are receiving this because you were mentioned.Message ID: @.***>