nisrael / sxda-scout-addon

Additional form fields for Eclipse Scout
Eclipse Public License 2.0
1 stars 1 forks source link

Good job! #16

Open rilent opened 1 month ago

rilent commented 1 month ago

Hello Nisrael, Just a small message to thank you for your work with this tool. I would love to see more JavaScript libraries implemented. I don’t have much time to dedicate to it currently, but I will try to contribute.

Few ideas :

pdf-viewer : https://www.npmjs.com/package/ng2-pdfjs-viewer Timeline : https://www.npmjs.com/package/vis-timeline

best regards

nisrael commented 1 month ago

Thanks for your feedback. I will Look into it. At the moment I am adding codemirror. Best Nils

rilent commented 1 month ago

Mixing JavaScript and Eclipse Scout can sometimes be quite challenging, and while your full example is great, my implementations often feel like patchwork.

I have two questions that I hope you can help me with to improve my skills. First, how do you maintain the responsiveness of the page? Second, how did you configure Ace Editor to use the theme from Eclipse Scout?

nisrael commented 1 month ago

First of all, are you using Scout JS or Scout Classic?

I haven't really paid attention to the responsiveness yet. But it should work in a real Scout application as long as the screen is not too small.

About the theme: In my real-world application, I provide a default light theme and a default dark theme, which the user can change in their preferences. The session will then provide the correct Ace theme, depending on the chosen Scout theme (light or dark).

rilent commented 1 month ago

I am using Scout Classic.

I went through your code and understood how the theme swap is implemented!