search

nisrulz / app-privacy-policy-generator

Generate a customized Privacy Policy and Terms of Use document for your mobile apps
https://app-privacy-policy-generator.nisrulz.com/
GNU Affero General Public License v3.0
3.94k stars 386 forks source link

Added Clerk Auth #180

Closed AaronMBMorse closed 1 year ago

AaronMBMorse commented 1 year ago

Added clerk authentication as an option.

nisrulz commented 1 year ago

Hi @AaronMBMorse , thank you for your PR. Everything looks good to me code wise, however your PR came from master branch which is an issue. You see, my Github Action workflow skips the job to publish a preview version of the webapp if the job was run on master branch.

It would be nice if you branched off your master and then sent the PR.

Additionally for future, I would suggest you to do the same flow as sending PR from master is not advised. Many open source devs create CI scripts that would skip a job if run on a branch that has master in it.

You can close this in favour of a new branch PR you create.

nisrulz commented 1 year ago

Closing this PR in favour of the one I created and merged.

Thank you raising this PR and your contribution.

AaronMBMorse commented 1 year ago

Thanks for the recommendation. I'll plan on that for the next PR.