Closed tsvillain closed 3 years ago
Thank you for your contribution. I will validate this first and then comment if it works :)
Thank you for your contribution. I will validate this first and then comment if it works :)
Okay No Issues
@tsvillain I took a look at your PR and noted few changes that would make this example app's PR complete:
Adding an entry in the readme with a link like other apps.
I noticed this PR sets up the app to use a URL to download the pdf and the display it.
An ability to load local pdf file from a assets directory within the app. That way you are covering both usecases i.e local file loading while also covering remote file loading via a URL. Within the app, that would mean that you now have 2 buttons at the beginning "Load PDF via URL" and "Load local PDF". When user clicks one, all buttons are hidden and progress shows up and then you load the file.
When the progress is showing, then the raised button shouldn't be visible. Right now it is showing up.
Okay will make the required changes.
@nisrulz the package you have recommended to use does not allow to load pdf from the asset. Can I use another package that can load from the asset as well as the URL? Can I use this: https://pub.dev/packages/advance_pdf_viewer
Yes, definitely. When I created the related issue, back then maybe this other package was not present.
But the idea was to cover both usecases. Switch the lib to support both usecase.
Thank you for bringing it up. :)
Yes, definitely. When I created the related issue, back then maybe this other package was not present.
But the idea was to cover both usecases. Switch the lib to support both usecase.
Thank you for bringing it up. :)
Thanks for the confirmation will update this PR in few hours.
@nisrulz in load from URL, I am loading the pdf that is in the assets folder using the full URL.
Constants.dart
I will add the code for you to start using the github based asset url. Give me some time. The PR looks good otherwise.
Good work @tsvillain 🌮 This looks good now. Thank you for your contribution 😸
Make sure to check other issues if your want contribute more 😄