Closed Rishika-7 closed 3 years ago
Corrected the package name in all the files
Also add a demo gif in the example directory and reference in readme. Check other example apps for reference.
I have made the changes according to the comments.
Looking better than last time. Good work @Rishika-7 !
I will give it a run later today.
Thank you
Thank you I have learnt a lot! Hoping it's upto the mark :)
@Rishika-7 everything looks good to me. I noticed 2 issues:
home.dart
file:
Solution will be to change the icon to Icons.exit_to_app
.
assets/
, which is wrong as it not a asset for the app but rather a demo gif file.
If you look at other examples in the repo, you will see the demo gif just sits in the root directory of the example app itself and is named demo.gif
. I would suggest to follow the same and also update the link in all readme, where you reference this gif.
Rest everything works!
I have made the changes!
Great!
I think this PR is ready to merged. Thank you for your contribution 🎉
Made the changes according to the guidelines, the package name and the branch name to the bottom sheet example app