search

nisrulz / flutter-examples

[Examples] Simple basic isolated apps, for budding flutter devs.
https://nisrulz.com/flutter-examples/
Apache License 2.0
6.91k stars 1.66k forks source link

Made the changes according to the guidelines to the bottom sheet example app #64

Closed Rishika-7 closed 3 years ago

Rishika-7 commented 3 years ago

Made the changes according to the guidelines, the package name and the branch name to the bottom sheet example app

Rishika-7 commented 3 years ago

Corrected the package name in all the files

nisrulz commented 3 years ago

Also add a demo gif in the example directory and reference in readme. Check other example apps for reference.

Rishika-7 commented 3 years ago

I have made the changes according to the comments.

nisrulz commented 3 years ago

Looking better than last time. Good work @Rishika-7 !

I will give it a run later today.

Thank you

Rishika-7 commented 3 years ago

Thank you I have learnt a lot! Hoping it's upto the mark :)

nisrulz commented 3 years ago

@Rishika-7 everything looks good to me. I noticed 2 issues:

  1. Inside home.dart file: Screenshot 2020-10-08 at 02 50 26

Solution will be to change the icon to Icons.exit_to_app.

  1. The screenshot for demo is placed under assets/, which is wrong as it not a asset for the app but rather a demo gif file. Screenshot 2020-10-08 at 02 53 26

If you look at other examples in the repo, you will see the demo gif just sits in the root directory of the example app itself and is named demo.gif. I would suggest to follow the same and also update the link in all readme, where you reference this gif.

Rest everything works!

Rishika-7 commented 3 years ago

I have made the changes!

nisrulz commented 3 years ago

Great!

I think this PR is ready to merged. Thank you for your contribution 🎉