search

nisrulz / flutter-examples

[Examples] Simple basic isolated apps, for budding flutter devs.
https://nisrulz.com/flutter-examples/
Apache License 2.0
6.91k stars 1.66k forks source link

Added Covid-19 Example app. #69

Closed mehdi1514 closed 3 years ago

mehdi1514 commented 3 years ago

Added an example app that uses NovelCOVID API to track Corona Virus cases. The app has two pages:

  1. Home Screen - shows Corona Virus cases in India by default(user can change this by changing the 'url2' variable).
  2. Affected Countries - show Corona Virus cases in different countries. Users can tap on the foldable tile to view details. He/she can also search for a country.

The packages used in this project are as follows:

  1. number_display - to display data in a width-limited component. For eg: it converts 2500000 to 2.5M
  2. http - to send HTTP requests to the API.
  3. bezier_chart - to visualize the received data from the API.
  4. folding_cell - to display a foldable cell to view details(total deaths, today cases, etc.). This foldable cell is present in the 'Affected Countries' page.

I hope this helps someone and saves their time. Thanks!

nisrulz commented 3 years ago

Did you read the contribution guidelines in Readme?

If you are starting out in OpenSource, please read about the ideal way to open a PR. Usually you would open an issue, discuss with maintainers and then once they give you a go, submit a PR against that issue you have opened. Once the PR merges, the issue is closed.

Why I am saying this, because opening random PR adds extra work on the maintainers to explain to you everything, which should be discussed upfront. You have just dropped a PR with no discussion around your implementation details and what is expected in this repository. Now it is the work for the maintainer to review this huge PR with 68 files changed/added and point out all the different ways it does not adhere to the right approach.

In the race to get a T-Shirt this Hacktoberfest you forgetting the value this brings, that is contributions in Open Source that you will learn from and start doing so more often.

nisrulz commented 3 years ago

Closing this PR since it doesn't adhere to the contribution guidelines.

Thank you for your contribution.

mehdi1514 commented 3 years ago

Thank you for your response Nishant. I completely agree with you. Since, I have just started with opensource, I was not aware of this. Also, the 'How to contribute' video on Hacktoberfest's website does not say anything about working on different branches and opening issues. I really want to contribute to this repository, not for the sole purpose of getting a T-Shirt, but adding some value to this repository.

I apologize for not adhering to the guidelines. I am eager to contribite to this repository, and so next time I follow the guidelines.

Thank you once again.

On Wed, 7 Oct 2020, 2:57 am Nishant Srivastava, notifications@github.com wrote:

Closed #69 https://github.com/nisrulz/flutter-examples/pull/69.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/nisrulz/flutter-examples/pull/69#event-3847635222, or unsubscribe https://github.com/notifications/unsubscribe-auth/AGLE6CIEZGRYDADMY4O6YEDSJODVJANCNFSM4SGNLF4Q .