search

nisrulz / flutter-examples

[Examples] Simple basic isolated apps, for budding flutter devs.
https://nisrulz.com/flutter-examples/
Apache License 2.0
6.91k stars 1.66k forks source link

API integration #71

Closed razorcalhn closed 3 years ago

razorcalhn commented 3 years ago

Example app to demonstrate API integration.

nisrulz commented 3 years ago

Did you read the contribution guidelines specified in the readme of this repo?

I see already it is not following some basics.

Also please add description to your PR, if you don't plan on opening an issue first. The ideal approach is to first open an issue, discuss the code you wish to contribute/improve in the repo and then once approved then open a PR.

I have no idea what you mean by "Example app to demonstrate API integration."

As of now I would take a few days to figure out what you are doing because I need to review your full PR which has 64 files 🤷‍♂️

razorcalhn commented 3 years ago

Yes, I did read the contribution guidelines specifies in the readme of this repo. It is not specified how descriptive the PR comment should be, if it is that important maybe it should be specified among other things in the readme file. I was told that short and clear was the best approach. It is not specified that it is a must to raise an issue first. I've seen other readme in the repo which only has a line of the description and a gif which is exactly what I did. Maybe if you provided a better description of what this project needs from other contributors, it would be a lot easier for others to comprehend as well as for you. Or maybe just add a separate contribution file. Anyway, thankyou for considering this. I am closing this PR now.

nisrulz commented 3 years ago

If you have something as an example to what you were expecting, do share. Always ready to learn and improve the guidelines if they are not as clear as they should.