search

nisrulz / flutter-examples

[Examples] Simple basic isolated apps, for budding flutter devs.
https://nisrulz.com/flutter-examples/
Apache License 2.0
6.94k stars 1.66k forks source link

[Fixes #97] Added a News & Memes App #99

Closed Sriraj-dev closed 1 year ago

Sriraj-dev commented 3 years ago

What does this implement/fix? Explain your changes

Adds a new app to display News and Memes

Does this close any currently open issues?

nisrulz commented 3 years ago

Can you add screenshots to the PR description as well as in the directory of your app?

Here is how it is done in another app in repo: https://github.com/nisrulz/flutter-examples/tree/develop/covid19_mobile_app

Sriraj-dev commented 3 years ago

Can you add screenshots to the PR description as well as in the directory of your app?

Here is how it is done in another app in repo: https://github.com/nisrulz/flutter-examples/tree/develop/covid19_mobile_app

Yes, @nisrulz Now, I have added the screenshots and a recording.

Thankyou.

Sriraj-dev commented 3 years ago

@nisrulz Is there any other issue with this PR?

nisrulz commented 3 years ago

In the video, few things I noted:

  1. Why do you need the smiley face? If it has no action then please remove it. The app is supposed to be bare minimum implementation.
  2. The news feed has 3D scrolling effect vs the Meme feed is swipe triggered. Would better if they both had the same style. Additionally you should get rid of the 3D scrolling effect and use the normal list scrolling effect. That is much better.
  3. Work on the design of the app a little bit. I did a quick mockup: Artboard-4 (1)
Sriraj-dev commented 3 years ago

In the video, few things I noted:

  1. Why do you need the smiley face? If it has no action then please remove it. The app is supposed to be bare minimum implementation.
  2. The news feed has 3D scrolling effect vs the Meme feed is swipe triggered. Would better if they both had the same style. Additionally you should get rid of the 3D scrolling effect and use the normal list scrolling effect. That is much better.
  3. Work on the design of the app a little bit. I did a quick mockup: Artboard-4 (1)

Ok, Fine @nisrulz , I have implemented two types of list views just to introduce the 3D-List view and its capability. Fine, will make the changes soon.

Thankyou

nisrulz commented 3 years ago

Actually the 3D List View can be another example app. The idea is to create the simplest and bare minimum apps in this repo. If you club multiple functionality then it defeats the purpose of the repository.

An individual app like yours should follow uniformity, hence my suggestion. In real world scenarios we don't ship proper apps that do CRUD with different design aesthetics.

Sriraj-dev commented 3 years ago

@nisrulz now, I have made all the changes mentioned above.

Thankyou.

Sriraj-dev commented 2 years ago

Any other issues to merge? @nisrulz