Open punksta opened 8 years ago
@punksta I donot fully understand what you are proposing here. Can you provide me with more details.
@nisrulz added samples;
@punksta I think using Singleton would be a nice change as cases of having multiple instances of the same QREader class are very less.
However I would not want to extend QREader to start supporting other reading capability just because I made it specifically to read QRCodes. However there is no harm in providing a config function that open ups the functionality if its desired. The way of implementation should be in such a way that it does not alienate the api to deviate from its core cause of reading QRCodes.
Would love to hear your thoughts on this too.
@nisrulz I agree. Where is another case of supporting external BarcodeDetector: using one instance for scanning of locally images and using in your reader.
What do you think about features:
com.google.android.gms.vision.barcode.BarcodeDetector
as singleton by default instead of creating new instance inside init() function. Do we really need different detectors in different readers?I already made it in my project and can make PR. But I'm not sure about first case.